Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#9499 closed defect (invalid)

The libamqp.c file has a plaintext password, and the amqp network protocol has security problems.

Reported by: wujian Owned by:
Priority: normal Component: avformat
Version: unspecified Keywords: libamqp
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by wujian)

Summary of the bug:
How to reproduce:

   if (!password || *password == '\0')
        password = "guest";

    password_decoded = ff_urldecode(password, 0);
    if (!password_decoded)
        return AVERROR(ENOMEM);

    user = credentials;
    if (*user == '\0')
        user = "guest";

Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker.

Change History (7)

comment:1 by wujian, 3 years ago

Description: modified (diff)

comment:2 by Marton Balint, 3 years ago

How is this a security issue?

in reply to:  2 comment:3 by wujian, 3 years ago

Replying to Marton Balint:

How is this a security issue?

If user and password is null, they will use the clear text "guest" as user and pasword to amqp_login.

comment:4 by Marton Balint, 3 years ago

Resolution: invalid
Status: newclosed

That is intentional, guest credentials are used because the protocol provides no means to skip authentication.

in reply to:  4 comment:5 by wujian, 3 years ago

Resolution: invalidfixed

Replying to Marton Balint:

That is intentional, guest credentials are used because the protocol provides no means to skip authentication.

thank you, i get it

comment:6 by Carl Eugen Hoyos, 2 years ago

Keywords: libamqp added; amqp network protocol security problems removed

comment:7 by Carl Eugen Hoyos, 2 years ago

Resolution: fixedinvalid
Note: See TracTickets for help on using tickets.