#7928 closed defect (invalid)
Regression in libswresample
Reported by: | Nomis101 | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | swresample |
Version: | git-master | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | no |
Description
Summary of the bug:
I regularly build HandBrake against the latest FFmpeg master to check if all works as expected or something is broken and I need to open a bug. With the latest master I found some issues (but I'm unsure if this is a regression or not).
After commit a9fa6b8e025cd138f8c3ed4cfa6d568bd79d0123 to swresample.c HB doesn't recognize the audio stream anymore, so the encoded file has no audio stream at all. This is true for every movie file and every output audio codec. The HB console is spilled a hundred times with the very same error
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
[01:15:37] decavcodec: hb_audio_resample_update() failed
[SWR @ 0x11a44a000] Requested input sample rate 0 is invalid
error: hb_audio_resample_update: swr_init() failed (Invalid argument)
error: Last error repeated 51 times
The altered code is used inside HB here:
https://github.com/HandBrake/HandBrake/blob/5a65df0d5838a3c8896ca0f5ce077cdf051358dc/libhb/encavcodecaudio.c#L254
FFmpeg itself works without any issue, so there is no FFmpeg output I could post. If this behavior is intended, then I will report it to HB.
Change History (2)
comment:1 by , 5 years ago
Keywords: | regression removed |
---|---|
Resolution: | → invalid |
Status: | new → closed |
This is obviously handbrake bug.