Opened 6 years ago
Closed 6 years ago
#7225 closed defect (fixed)
fate-filter-hls-append test fails if system time is not set
Reported by: | James Cowgill | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | build system |
Version: | git-master | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | no |
Description
Summary of the bug:
The fate-filter-hls-append
test fails if the system time is not set (ie it's around 1970 on unix).
How to reproduce:
$ sudo date -s '1971-01-01' # or $ sudo apt install faketime $ NO_FAKE_STAT=1 faketime '1971-01-01' $SHELL # then $ make fate-filter-hls-append V=1
Results:
All the timestamps are incorrect. The exact timestamps given depend on the system time.
--- ./tests/ref/fate/filter-hls-append 2018-04-10 14:11:38.583878637 +0100 +++ tests/data/fate/filter-hls-append 1971-01-01 00:00:03.875946672 +0100 @@ -4,1535 +4,1535 @@ #sample_rate 0: 44100 #channel_layout 0: 4 #channel_layout_name 0: mono -0, 0, 0, 1152, 2304, 0x907cb7fa -0, 1152, 1152, 1152, 2304, 0xb8dc7525 -0, 2304, 2304, 1152, 2304, 0x3e7d6905 -0, 3456, 3456, 1152, 2304, 0xef47877b -0, 4608, 4608, 1152, 2304, 0xfe916b7e -0, 5760, 5760, 1152, 2304, 0xe3d08cde -0, 6912, 6912, 1152, 2304, 0xff7f86cf -0, 8064, 8064, 1152, 2304, 0x843e6f95 [...] +0, 31532403687197, 31532403687197, 1152, 2304, 0x907cb7fa +0, 31532403687468, 31532403687468, 1152, 2304, 0xb8dc7525 +0, 31532403687611, 31532403687611, 1152, 2304, 0x3e7d6905 +0, 31532403687745, 31532403687745, 1152, 2304, 0xef47877b +0, 31532403687876, 31532403687876, 1152, 2304, 0xfe916b7e +0, 31532403688008, 31532403688008, 1152, 2304, 0xe3d08cde +0, 31532403688138, 31532403688138, 1152, 2304, 0xff7f86cf +0, 31532403688270, 31532403688270, 1152, 2304, 0x843e6f95 [...]
I notice that fate-filter-hls-append
passes -af asetpts=RTCTIME
to ffmpeg which is clearly going to depend on the system time - I don't think tests should be doing that.
Tested with:
ffmpeg version N-91146-gfe84f70819 Copyright (c) 2000-2018 the FFmpeg developers
Change History (3)
follow-up: 2 comment:1 by , 6 years ago
comment:2 by , 6 years ago
comment:3 by , 6 years ago
Component: | undetermined → build system |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fixed by Steven Liu in 387464bea5bdd81f6c61e12680a1cb55c57551e0
Note:
See TracTickets
for help on using tickets.
try this patch please:
https://patchwork.ffmpeg.org/patch/9067/