Corrupt file crashes ffmpeg with assertion failure.

[Dale Curtis]

Using master branch, run ffmpeg -i on the attached file and observe the following:

[ogg @ 0x125f380] Codec not found
[ogg @ 0x125f380] Invalid timing values.

Last message repeated 1 times

[ogg @ 0x125f380] Header parsing failed for stream 1
[ogg @ 0x125f380] Header parsing failed for stream 2
[ogg @ 0x125f380] Headers mismatch for stream 3: expected 2 received 0.
[ogg @ 0x125f380] New streams are not supposed to be added in between Ogg context save/restore operations.
[ogg @ 0x125f380] failed to create or replace stream
[ogg @ 0x125f380] Codec not found
[ogg @ 0x125f380] Invalid timing values.
Assertion 0 failed at libavcodec/gsm_parser.c:59
Aborted (core dumped)

Seems this should return an error instead of crashing, but the parse() api doesn't seem to provide a way for error codes to be returned.

[Cigaes]

The assert is fine, the execution should not arrive there in the first place.

You should run your fuzzing tests with the highest assert level, it would have triggered an assert failure earlier.

I do not know the Ogg and parser infrastructure well enough to investigate further.

[Carl Eugen Hoyos]

Regression since 6f69f7a8bf6a0d013985578df2ef42ee6b1c7994

[Dale Curtis]

Ah, I think the issue is that AVERROR codes from oggdec->header() aren't handled at all. Will submit a patch shortly.

[Carl Eugen Hoyos]

Fixed by you in 09494d098405738a5972e0052110af65b3ff7e72