Opened 7 years ago
Closed 5 years ago
#6741 closed defect (fixed)
ffmpeg-3.4/libavfilter/vf_cover_rect.c:155: suspicious if ?
Reported by: | dcb | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | avfilter |
Version: | git-master | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | no |
Description (last modified by )
ffmpeg-3.4/libavfilter/vf_cover_rect.c:155] -> [ffmpeg-3.4/libavfilter/vf_cover_rect.c:155]: (style) Same expression on both sides of ||
.
Source code is
if (!xendptr || *xendptr || !yendptr || *yendptr || !wendptr || *wendptr || !hendptr || !hendptr
maybe better code
if (!xendptr || *xendptr || !yendptr || *yendptr || !wendptr || *wendptr || !hendptr || !*hendptr
Change History (1)
comment:1 by , 5 years ago
Component: | undetermined → avfilter |
---|---|
Description: | modified (diff) |
Resolution: | → fixed |
Status: | new → closed |
Version: | unspecified → git-master |
Note:
See TracTickets
for help on using tickets.
Fixed by Jun Zhao in c9671289521226dd7d3213377a14331e73cb6283