Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#518 closed defect (fixed)

The range of mpegts_pmt_start_pid is unnecessarily restrictive.

Reported by: Loren Owned by: Michael Niedermayer
Priority: normal Component: avformat
Version: git-master Keywords: mpegts
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

I am trying to create CableLabs compliant VOD streams using ffmpeg. The spec for these files (CableLabs Video-On-Demand Content Encoding Profiles Specification: ​http://www.cablelabs.com/projects/metadata/downloads/specs/MD-SP-VOD-CEP-I01-040107.pdf ) requires that the PMT have a PID of 0x01E0, decimal 480 (see section 4.5 on page 6). The lower bound on the mpegts_pmt_start_pid which appears to set the PID of the PMT has been given an artificial lower-bound of 0x1000, decimal 4096. Given this artificial lower bound, I can not set the PID to conform to the spec. My understanding is that PIDs less than 16 are reserved, but otherwise, I am unsure of any other reason for restricting the lower bound of the PMT PID. I have attached a minor patch that simply changes the lower bound on this particular argument. Please comment if you know of any problem this could cause elsewhere.

Thank you,

-Loren Osborn

Attachments (1)

ffmpeg-mpegts_pmt_start_pid_range_error.diff​ (913 bytes ) - added by Loren 13 years ago.

Download all attachments as: .zip

Change History (4)

by Loren, 13 years ago

Attachment: ffmpeg-mpegts_pmt_start_pid_range_error.diff​ added

comment:1 by Carl Eugen Hoyos, 13 years ago

Component: FFmpeg → avformat
Status: new → open

Consider sending patches to ffmpeg-devel.

comment:2 by Michael Niedermayer, 13 years ago

Resolution: → fixed
Status: open → closed

Patch applied, thanks

comment:3 by Carl Eugen Hoyos, 11 years ago

Keywords: mpegts added; PMT PID Video-on-Demand VOD specifications MPEG Transport Stream TS removed
Note: See TracTickets for help on using tickets.