unicode under windows

[Anton Sergunov]

It will be nice to make unicode wrapper for main() under win32.

somthing like this

int wmain(int argc, wchar_t* argv[])
{
    char** cargs = new char*[argc];
    for(int i=0; i<argc; ++i)
    {
        int len = WideCharToMultiByte(CP_UTF8, 0, argv[i], -1, NULL, -1, NULL, NULL);
        if(len < 0)
            len = 0;
        cargs[i] = new char[len+1];
        len = WideCharToMultiByte(CP_UTF8, 0, argv[i], -1, cargs[i], len, NULL, NULL);
        cargs[i][len] = 0;
    }
    int ret = ffmpeg_main(argc, cargs); // rename your main
    for(int i=0; i<argc; ++i)
        delete[] cargs[i];
    delete[] cargs;

    return ret;
}

ffmpeg -metadata treats input char strings as utf8 strings, but under windows it's not true. They comes to main() as local single char encoding. Determinate local encoding in tagger not always right. Because some symbols may not covered by local encoding

[Anton Sergunov]

But opening files trough fopen or fstream. Those function will fails on symbols which not in latin1 codepage

[Michael Niedermayer]

note, few ffmpeg developers have windows systems, thus it might help if you send a patch

[reimar]

This issue has been fixed differently a long time ago.

[Roger Pack]

could somebody point me to the diff that fixed this by chance?

[gjdfgh]

You'll have to find it yourself, but look at prepare_app_arguments() in cmdutils.c.