Seg fault in h264 when error resilience is disabled

[Matt Wolenetz]

Summary of the bug:
It looks like there is incomplete removal of error-resilience code, even with --disable-error-resilience, causing this segfault in h264 decode_slice. I will attach console output from my repro "h264_er_disabled_segfault.log".

How to reproduce:

There may be a simpler repro.
FFmpeg maintainer already has test2.asan.0.9052.mov.

% ./configure --disable-everything --disable-avdevice --disable-avfilter --disable-bzlib --disable-doc --disable-ffprobe --disable-lzo --disable-network --disable-postproc --disable-swresample --disable-swscale --disable-zlib --enable-fft --enable-rdft --enable-shared --disable-iconv --disable-dxva2 --disable-vaapi --disable-vda --disable-vdpau --optflags=-O2 --enable-decoder='theora,vorbis,vp8' --enable-decoder='pcm_u8,pcm_s16le,pcm_s24le,pcm_f32le' --enable-decoder='pcm_s16be,pcm_s24be' --enable-demuxer='ogg,matroska,wav' --enable-parser='vp3,vorbis,vp8' --enable-pic --enable-decoder='aac,h264,mp3' --enable-demuxer='mp3,mov' --enable-parser='aac,h264,mpegaudio' --disable-error-resilience --disable-optimizations --extra-cflags='-fno-inline -fno-omit-frame-pointer -fno-builtin -fno-optimize-sibling-calls' --enable-debug --enable-static --disable-shared --enable-protocol=file --enable-avfilter --enable-swscale --enable-swresample --enable-ffmpeg && make clean && make -j32 && ../../trunk/src/third_party/valgrind/linux_x64/bin/valgrind --tool=memcheck --num-callers=30 --gen-suppressions=all --demangle=no --leak-check=yes --show-possibly-lost=no ./ffmpeg_g -i test2.asan.0.9052.mov -f null - 2>&1

ffmpeg from git-master (13cb6ed3c449c57c605653943f7d6168afa10bf9)
built on linux x64

Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker.

[Michael Niedermayer]

Fixed in bbe26eff2235dc2d1c79a5a1e25b46d8d7f0fe08