[regression] Smacker audio played with clicks

[Sergey]

You can clearly hear audio clicks when playing some smk files by mplayer/ffplay

The bug was introduced by ffmpeg commit 375ca0aca81be2951d9ba4731196e70e490d3cdf
It was a little bit "fixed" later by commit 12cbbbb4abda2de0ea123282ccf7ebee61517f7d
but clicks are still there.

Sample file (20130402_vc-error_sound-clicks.smk) is ~12MB,
so it was uploaded to ​ftp://upload.ffmpeg.org/
Noticeable clicks are near 20-27 seconds of this sample.

[Carl Eugen Hoyos]

I don't see the file on upload.ffmpeg.org, consider uploading it to ​http://www.datafilehost.com/

[Sergey]

​http://www.datafilehost.com/download-4dc465b2.html

[Carl Eugen Hoyos]

Output file contains audible distortions, works fine with dec354b and FFmpeg 0.8.

$ ffmpeg -i 20130402_vc-error_sound-clicks.smk -ss 19 -t 10 out.wav
ffmpeg version N-51524-gccc2537 Copyright (c) 2000-2013 the FFmpeg developers
  built on Apr  2 2013 23:34:39 with gcc 4.7 (SUSE Linux)
  configuration: --enable-gpl --disable-indev=jack
  libavutil      52. 24.100 / 52. 24.100
  libavcodec     55.  2.100 / 55.  2.100
  libavformat    55.  1.100 / 55.  1.100
  libavdevice    55.  0.100 / 55.  0.100
  libavfilter     3. 48.105 /  3. 48.105
  libswscale      2.  2.100 /  2.  2.100
  libswresample   0. 17.102 /  0. 17.102
  libpostproc    52.  2.100 / 52.  2.100
[smk @ 0x1931f80] max_analyze_duration 5000000 reached at 5066160 microseconds
Input #0, smk, from '20130402_vc-error_sound-clicks.smk':
  Duration: 00:00:52.46, start: 0.000000, bitrate: 1843 kb/s
    Stream #0:0: Video: smackvideo (SMK2 / 0x324B4D53), pal8, 320x308, 15 fps, 15 tbr, 15 tbn, 15 tbc
    Stream #0:1: Audio: smackaudio (SMKA / 0x414B4D53), 22050 Hz, stereo, s16
Output #0, wav, to 'out.wav':
  Metadata:
    ISFT            : Lavf55.1.100
    Stream #0:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 22050 Hz, stereo, s16, 705 kb/s
Stream mapping:
  Stream #0:1 -> #0:0 (smackaud -> pcm_s16le)
Press [q] to stop, [?] for help
size=     861kB time=00:00:10.06 bitrate= 701.1kbits/s
video:0kB audio:861kB subtitle:0 global headers:0kB muxing overhead 0.009071%

[Michael Niedermayer]

Fixed by reverting the cliping code in 2211c76287e073a9e176fde7dbb9a63ceb2af8d1