Opened 12 years ago
Closed 9 years ago
#1463 closed enhancement (fixed)
ffmpeg.exe on Windows does not respond properly to Ctrl+Break
Reported by: | Joe Wreschnig | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | ffmpeg |
Version: | git-master | Keywords: | win |
Cc: | Roger Pack | Blocked By: | |
Blocking: | Reproduced by developer: | no | |
Analyzed by developer: | no |
Description
In addition to SIGINT, on Windows it is common to send a different signal, SIGBREAK, which has similar effects. This can be triggered by pressing Ctrl+Break or by another process sending a signal.
New process groups on WIn32 usually ignore SIGINT; it is customary to stop a process in a separate process group by sending SIGBREAK.
The attached patch makes ffmpeg.exe respond to SIGBREAK in the same way it does SIGINT, using the WIndows console "control event" handler.
Attachments (1)
Change History (8)
by , 12 years ago
Attachment: | ffmpeg-sigbreak.diff added |
---|
comment:1 by , 12 years ago
Keywords: | win added |
---|---|
Status: | new → open |
Version: | unspecified → git-master |
Please send patches to ffmpeg-devel, they receive more attention there.
follow-up: 3 comment:2 by , 12 years ago
appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz
comment:3 by , 12 years ago
Cc: | added |
---|
Replying to rogerdpack:
appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz
If you want to push this patch, please resend a tested version to ffmpeg-devel. Posting a link (especially a non-working one) unfortunately does not help.
comment:4 by , 12 years ago
See also http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=7&t=1133 which may be useful
comment:5 by , 12 years ago
If you are interested in this issue please consider reading my last comment.
comment:6 by , 9 years ago
(I would note also that ctrl+c [or sending the process the CTRL_C_EVENT] does/did already work, FWIW).
comment:7 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | open → closed |
OK finally got a commit in for this, thanks for the patch!
Patch against ~2012.06.18 git branch