Aspect ratio defined by the JFIF segment APP0 is misinterpreted as its reciprocal

[goodbye]

The JFIF APP0 segment describes the resolution/pixel density of an image, which can be in abstract units (in which case it only defines the pixel aspect ratio), in pixels per inch, or in pixels per centimetre. See for example ​ECMA TR/98 1st Ed. §6.4 and §10.

FFmpeg interprets the X:Y resolution ratio directly as a X:Y PAR, but in actuality, it’s the reciprocal. This is because the resolution is specified as a “pixels per unit” value and not “units per pixel”, as is typically the case with PARs. The X:Y PAR is equal to the Y:X ratio of resolutions specified in the segment.

The attached image is supposed to have a DAR of 1:1, but FFmpeg misinterprets it to have a DAR of 4:1.

The issue has been present from the very beginning, since aspect ratio decoding was re-enabled in commit 5ff85f1d8b5721a9e7f0ca6e03f61f5d3a4c3664 (libavcodec/mjpeg.c lines 384–385; now libavcodec/mjpegenc.c lines+ 1904–1905). In fact, it has never worked very well – previous code seemed to misinterpret the density ratio as the DAR.

The MJPEG encoder has the complementary problem of writing the reciprocal ratio into the APP0 segment (libavcodec/mjpegenc_common.c lines 189–190)

[goodbye]

sample file with non-square DPI