Opened 6 years ago

Closed 21 months ago

#7217 closed defect (fixed)

ffprobe produces wrong XML; "data_hash" attribute sometimes in text

Reported by: Carl Reinke Owned by:
Priority: normal Component: ffprobe
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

The "data_hash" attribute is sometimes in the text instead of in the tag.

How to reproduce:

$ ffprobe -v 0 -print_format xml=xsd_strict=1 -show_packets -show_data_hash sha160 -noshow_private_data -read_intervals %+#1 kahvi048_pinza-thickline.ogg
<?xml version="1.0" encoding="UTF-8"?>
<ffprobe:ffprobe xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ffprobe='http://www.ffmpeg.org/schema/ffprobe' xsi:schemaLocation='http://www.ffmpeg.org/schema/ffprobe ffprobe.xsd'>
    <packets>
        <packet codec_type="audio" stream_index="0" pts="-128" pts_time="-0.002902" dts="-128" dts_time="-0.002902" duration="128" duration_time="0.002902" size="60" pos="4315" flags="K_">
            <side_data_list>
                <side_data side_data_type="Metadata Update"/>
            </side_data_list>
 data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381"        </packet>
    </packets>
</ffprobe:ffprobe>

File used is available ​here.

Change History (8)

comment:1 by Carl Eugen Hoyos, 6 years ago

Version: 3.2.4 → git-master

comment:2 by Balling, 5 years ago

Status: new → open

Yep... So where should it be? Like in <side_data data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381"> or where?

comment:3 by Carl Reinke, 5 years ago

According to ​the schema, it should be on an attribute on the "packet" tag.

Version 0, edited 5 years ago by Carl Reinke (next)

comment:4 by Stefano Sabatini, 2 years ago

Cannot reproduce with latest master f7dd408d64013ae177c1f8d0e04418e5075db5bc.

Can you provide a sample reproducing this issue?

This or we should mark this as resolved.

comment:5 by Balling, 2 years ago

The file after redirect is here: ​https://http.hu.scene.org/music/groups/kahvicollective/kahvi048_pinza-thickline.ogg

It still happens, data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381" should be in <packet codec_type="audio" data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381">

comment:6 by Stefano Sabatini, 2 years ago

Thanks for the sample, I was able to reproduce, patch sent to ML.

in reply to:  7 comment:8 by Stefano Sabatini, 21 months ago

Resolution: → fixed
Status: open → closed

Replying to Balling:

​https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220807230356.659151-1-stefasab@gmail.com/

VERY NICE!!!

Sorry for the long wait, fixed in commit ​843a4467131fd677aacb46.

Note: See TracTickets for help on using tickets.